Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up edl_cmd_shell for os commands #44

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Commits on Oct 7, 2024

  1. Fix up edl_cmd_shell for os commands

    When invoked as "sdo_write c3 os_command command ..." this patch fixes
    two thing:
    - ... can now have spaces in it
    - command is defined as DOMAIN which we didn't handle. There's some
      amount of stuff built around the assumption that we don't use DOMIAIN
      at all but this is what we shipped so we've got to support it now.
      Amusingly it looks like pycanopen's `encode_raw()` has a bug where it
      doesn't convert strings to bytes correctly so it's done manually here.
    ThirteenFish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5f961ed View commit details
    Browse the repository at this point in the history
  2. Fix cfdp-py to 0.1.2

    cfdp-py has updated with handy bug fixes! Unfortunately those conflict
    with our fixes so until we can properly ship a new version to space
    let's fix the version to what we've been developing with.
    ThirteenFish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bc3a664 View commit details
    Browse the repository at this point in the history
  3. Print current sequence number in CFDP script

    Similar to cmd_shell and ping, this makes it easy to coordinate with
    those other scripts.
    ThirteenFish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    aba6d17 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Handle sdo writes to type DOMAIN and OCTET_STRING in edl_cmd_shell

    In 5f961ed I added DOMAIN handling so that we could send os commands,
    but DOMAIN really is supposed to be for file-like things. This enhances
    sdo_write to interpret the final argument instead as a filename, which
    it then opens and sends.
    
    Additionally os commands really should have been of type OCTET_STRING
    but that needs to be fixed in oresat-configs. This adds OCTET_STRING
    handling in anticipation of that.
    ThirteenFish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    36f4d54 View commit details
    Browse the repository at this point in the history