Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaitai Struct Generator #31

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Kaitai Struct Generator #31

merged 11 commits into from
Aug 13, 2024

Conversation

dmitri-mcguckin
Copy link
Member

@dmitri-mcguckin dmitri-mcguckin commented Jul 7, 2024 •
edited
Loading

Add first pass at kaitai struct generator.

Outstanding questions:

  • What are our sequence types?

Needs before Approval:

  • Manual regression testing with sbt

@dmitri-mcguckin dmitri-mcguckin added the enhancement New feature or request label Jul 7, 2024
@dmitri-mcguckin dmitri-mcguckin self-assigned this Jul 7, 2024
@ryanpdx ryanpdx linked an issue Jul 8, 2024 that may be closed by this pull request
SatNOGS Kaitai generator #30
Closed
ryanpdx
ryanpdx reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@ryanpdx ryanpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to support enums and bitfields at a later date?

The changes to all argparse messages is a little out of scope for this issue/PR

pyproject.toml Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
ThirteenFish
ThirteenFish requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ThirteenFish ThirteenFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've still got to review the Kaitai content itself so this is a bit backwards in focusing on the little things first, but this is something to get started on.

pyproject.toml Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
ThirteenFish
ThirteenFish requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@ThirteenFish ThirteenFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried compiling the generated file and this was the result.

oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
oresat_configs/scripts/gen_kaitai.py Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
@dmitri-mcguckin dmitri-mcguckin merged commit e7be40a into master Aug 13, 2024
1 check passed
@dmitri-mcguckin dmitri-mcguckin deleted the feat/kaitai branch August 13, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanpdx ryanpdx ryanpdx approved these changes

@ThirteenFish ThirteenFish ThirteenFish approved these changes

Assignees

@dmitri-mcguckin dmitri-mcguckin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SatNOGS Kaitai generator
3 participants
@dmitri-mcguckin @ThirteenFish @ryanpdx