Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing crc32 to beacon in xtce generator #32

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

ryanpdx
Copy link
Member

@ryanpdx ryanpdx commented Jul 13, 2024

The tailing CRC32 field was missing from the XTCE generator

It is hard-coded as it is a fully generated value and not in the C3's OD

Copy link
Contributor

@ThirteenFish ThirteenFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now 3 uint32 types in the generated xtce, uint32_type, uint32_s_type and uint32_B_type. Would it make sense to either consolidate them or rename this hard-coded type to be something like uint32_crc_type or just crc32_type?

Other than that this looks good.

oresat_configs/scripts/gen_xtce.py Outdated Show resolved Hide resolved
@ryanpdx
Copy link
Member Author

ryanpdx commented Jul 14, 2024

There's now 3 uint32 types in the generated xtce, uint32_type, uint32_s_type and uint32_B_type. Would it make sense to either consolidate them or rename this hard-coded type to be something like uint32_crc_type or just crc32_type?

The type names current follow [datatype]_type for types without units or [datatype]_[unit]_type for types with units.

The uint32_type is already shared by other fields in the beacon, I just hard-coded it to make sure it always exist for the CRC.

@ThirteenFish ThirteenFish merged commit 88ce292 into master Jul 14, 2024
1 check passed
@ThirteenFish ThirteenFish deleted the xtce-crc32 branch July 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants