Diode test card OD

[chroco]

These are the updates to the OD for the diode test card.

[ThirteenFish]

I'd like to see more usage of the descriptive fields where applicable. These include:

• unit and scale_factor. Prefer standard units like A or S and then use scale_factor to scale them to the actual value you put in the subindex. For example if you report led_current in uA, then set uint to A and scale_factor to 0.000001.
• high_limit and low_limit. Only if the limits are readily available, otherwise the whole range is valid.
• value_descriptions. For enum-like things. Probably ctrl?
• bit_definitions. For bitfield like things. Probably error and status?
• default. Where a default value would make sense. Maybe ctrl and mux_select?

You can find some documentation here but there's also examples in other configs on how to use them.

[chroco]

Thanks Theo! I'll work on these changes. I think I am blocked on the units and scale_factor in the adcsample portion of the OD until I have more information from Anna and Andrew. That's why this is left as uint. This portion of the code is unfinished in app_diode as well as the bit fields in error and status. I also don't expect all the bits to be used at this time. Do you want me to put placeholders in for the unknowns?

[ThirteenFish]

I think I am blocked on the units and scale_factor in the adcsample portion of the OD until I have more information from Anna and Andrew.

If it's unknown it's fine to leave the units off until they're determined. An alternative idea, since this is ADC output, is to mark the unit as lsb for least significant bits. That's kinda the generic "here's an ADC" unit. Once the real unit is determined we can update the config.

This portion of the code is unfinished in app_diode as well as the bit fields in error and status. I also don't expect all the bits to be used at this time. Do you want me to put placeholders in for the unknowns?

No need for placeholders, only mark the bits that you use. As more bits get used the configs can be updated. If none are currently used you could possibly add a comment saying "currently unused" or something to that effect.