Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator bugs #38

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Fix generator bugs #38

merged 2 commits into from
Aug 16, 2024

Conversation

dmitri-mcguckin
Copy link
Member

Problem Statement:

Theo and I discovered several bugs with the kaitai generator which caused incorrect packet parsing or straight-out crashing of the parser

Updates:

  • AX25 Info payload would incorrectly read to the end of the packet
    • Disabling the CRC from being loaded
  • Callsign processor type was set to non-existant repeater type instead of the satnogs recommended ror(1) (right-shifting the callsign bytestring)
  • Add dynamic payload-size calculation while populating AX25 Info Data frame

Impact:

Kaitai struct is ready for release to SatNOGS DB + Network

@dmitri-mcguckin dmitri-mcguckin added the bug Something isn't working label Aug 15, 2024
@dmitri-mcguckin dmitri-mcguckin self-assigned this Aug 15, 2024
Copy link
Contributor

@ThirteenFish ThirteenFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference It looks like we could have also removed the size field instead of calculating a fixed size, but that's not been tested and this has been.

@dmitri-mcguckin dmitri-mcguckin merged commit 4fcec8d into master Aug 16, 2024
1 check passed
@dmitri-mcguckin dmitri-mcguckin deleted the fix/kaitai branch August 16, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants