Skip to content

Commit

Permalink
Fix bazel coverage build on Jenkins
Browse files Browse the repository at this point in the history
Summary:
Coverage runs were getting `nobuild_runfile_links` from a expansion
of `remote_download_minimal`. This happens to cause issues. So explicitly
set `build_runfile_links` for coverage runs.

See bazelbuild/bazel#4685 (comment)

Test Plan: Ran the coverage build, most of the failures go away.

Reviewers: zasgar, michelle, jamesbartlett

Reviewed By: jamesbartlett

Signed-off-by: Vihang Mehta <[email protected]>

Differential Revision: https://phab.corp.pixielabs.ai/D11654

GitOrigin-RevId: d469d5d
  • Loading branch information
vihangm authored and orishuss committed Jul 14, 2022
1 parent 9d23bc4 commit 294dd8b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 1 addition & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ build --host_action_env=CLANG_COMPILER_VERSION=14.0_0
build --remote_download_minimal
test --remote_download_minimal
run --remote_download_toplevel
coverage --build_runfile_links

build:clang --action_env=CC
build:clang --host_action_env=CC
Expand Down Expand Up @@ -202,8 +203,6 @@ coverage --instrument_test_targets
coverage --define PL_COVERAGE=true
coverage --copt -DPL_COVERAGE
coverage --test_tag_filters=-requires_root,-requires_bpf,-no_coverage,-disabled,-no_gcc
# Uploading to BES from the coverage build seems to fail on jenkins.
coverage --experimental_build_event_upload_strategy=local

# Use stable GIT build tag by default.
build --define BUNDLE_VERSION={STABLE_BUILD_TAG}
Expand Down
3 changes: 3 additions & 0 deletions ci/jenkins.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,6 @@ test --local_cpu_resources=14

build --jobs 16
test --jobs 16

# Uploading to BES from the coverage build seems to fail on jenkins.
coverage --experimental_build_event_upload_strategy=local

0 comments on commit 294dd8b

Please sign in to comment.