Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch size finder calling wrong super class functions #85

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Batch size finder calling wrong super class functions #85

merged 4 commits into from
Dec 5, 2023

Conversation

lorenzomammana
Copy link
Contributor

Summary

Fix wrong call to super function in BatchSizeFinder callback.
Fix hardcoded value in model manager

closes #84

Type of Change

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@lorenzomammana lorenzomammana marked this pull request as ready for review December 1, 2023 17:02
@lorenzomammana lorenzomammana merged commit 8147e2d into main Dec 5, 2023
2 checks passed
@lorenzomammana lorenzomammana deleted the hotfix/batch-size-finder branch December 5, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmalli rcmalli rcmalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get latest version not working properly in mlflow model manager
2 participants
@lorenzomammana @rcmalli