Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hydra plugin integration #94

Merged
merged 6 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
# Changelog
All notable changes to this project will be documented in this file.

### [1.5.2]

#### Fixed

- Fix hydra plugin not working properly when the library is installed from external sources.

### [1.5.1]

#### Fixed
Expand Down
15 changes: 6 additions & 9 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "quadra"
version = "1.5.1"
version = "1.5.2"
description = "Deep Learning experiment orchestration library"
authors = [
"Federico Belotti <[email protected]>",
Expand All @@ -25,7 +25,10 @@ classifiers = [
]
homepage = "https://orobix.github.io/quadra"
repository = "https://github.com/orobix/quadra"
packages = [{ include = "quadra" }, { include = "quadra_hydra_plugin" }]
packages = [
{ include = "quadra" },
{ include = "hydra_plugins", from = "quadra_hydra_plugin" },
]

[build-system]
requires = ["poetry-core>=1.0.0"]
Expand All @@ -37,7 +40,8 @@ quadra = "quadra.main:main"
[tool.poetry.dependencies]
python = ">=3.9,<3.11"
poetry = "1.7.1"
hydra-plugins = { path = "./quadra_hydra_plugin" }
# This will make hydra-plugins available also when running with poetry install
hydra-plugins = { path = "quadra_hydra_plugin", optional = true }
# TODO: We could support previous torch version using mutually exclusive python version but it's bad...
# TODO: Right now it seems that poetry will download every kind of possible dependency from cu116
# To make it faster we could hardcode the correct version of the dependencies
Expand Down Expand Up @@ -153,6 +157,7 @@ dev = [
"mike",
"cairosvg",
"poetry-dynamic-versioning",
"hydra-plugins",
]

test = [
Expand Down
2 changes: 1 addition & 1 deletion quadra/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "1.5.1"
__version__ = "1.5.2"


def get_version():
Expand Down
14 changes: 5 additions & 9 deletions quadra_hydra_plugin/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,13 @@ name = "hydra_plugins"
version = "1.0.0"
description = "Hydra plugin allowing the discovery of external configurations"
authors = [
"Federico Belotti <[email protected]>",
"Silvia Bianchetti <[email protected]>",
"Refik Can Malli <[email protected]>",
"Lorenzo Mammana <[email protected]>",
"Alessandro Polidori <[email protected]>",
"Federico Belotti <[email protected]>",
"Silvia Bianchetti <[email protected]>",
"Refik Can Malli <[email protected]>",
"Lorenzo Mammana <[email protected]>",
"Alessandro Polidori <[email protected]>",
]

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

[tool.poetry.dependencies]
python = ">=3.9,<3.11"
poetry = "1.7.1"