rtt_ros2_topics: update RTT plugin name to "rostopic" to match "rosnode" and "rosparam" #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concludes on #18 (Reconsider service names) (closes #18):
Package
rtt_ros2_topicsprovides the service plugin "rostopic" now. At the moment therostopicservice cannot be loaded into a component. It only provides additional operations in the global serviceros, which is why the string returned bygetRTTPluginName()does not really matter. That might change in the future for addressing ROS topic transport improvements #16.The service and plugin name provided by package
rtt_ros2_paramswas changed to"rosparam"in b62ddea after a PR review of Add support for ROS2 parameters #7.The service and plugin name provided by package
rtt_ros2_nodewas already changed to"rosnode"in be27f6e and f6e9fe5 (Add support for ROS2 parameters #7).