Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(field): programmatically associate inputs with field messages #1021

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

mlmoravek
Copy link
Member

Fixes #935

Proposed Changes

  • Improve a11y by:
    • Add a unique ID to the field message p element.
    • Make the attributes defined by the field available for inputs.
    • Bind the attributes defined by the field to the input element.

@mlmoravek mlmoravek added the feature A new feature label Jul 12, 2024
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit eac328a
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6698e290c330d00008c061c9
😎 Deploy Preview https://deploy-preview-1021--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek
Copy link
Member Author

@mmazanec22 could you please a have a look about this PR, if it suits your feature request? Thanks a lot!! :)

@mlmoravek mlmoravek added the a11y Accessibility label Jul 12, 2024
@mlmoravek mlmoravek merged commit 6fc309f into develop Jul 19, 2024
9 of 10 checks passed
@mlmoravek mlmoravek deleted the feat/input-aria branch July 19, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatically associate inputs with field messages
1 participant