Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): prevent background scrolling on mobile #1022

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Jul 12, 2024

Fixes #497

Proposed Changes

  • extract Modal background scolling handler to usePreventScrolling composable
  • use usePreventScrolling composable in Modal and Dropdown

@mlmoravek mlmoravek added the bug Something isn't working label Jul 12, 2024
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 4c0b1d7
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/66923a6f5b723b0008ccaf1e
😎 Deploy Preview https://deploy-preview-1022--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek merged commit bc1b497 into develop Jul 17, 2024
10 checks passed
@mlmoravek mlmoravek deleted the feat/dropdown/scroll branch July 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Background should not be scrollable on mobile
1 participant