Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): remove variant prop | improve prop definitions #1046

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

mlmoravek
Copy link
Member

Proposed Changes

  • remove variant prop (and class) because it has not other usecase then adding a class
  • update prop definitions
    • add strict values
    • define default values more strict

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit fc5fa75
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/66e96a6043bb830008a3d33f
😎 Deploy Preview https://deploy-preview-1046--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek merged commit c6bd1bc into develop Sep 17, 2024
10 checks passed
@mlmoravek mlmoravek deleted the feat/sidebar/simplify branch September 17, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant