-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(programmatic): unfiy useProgramamtic
interfaces
#1058
Open
mlmoravek
wants to merge
10
commits into
develop
Choose a base branch
from
feat/programmatic
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlmoravek
added
breaking
Breaking changes
refactoring
This involves some refactoring of existing code.
labels
Sep 20, 2024
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mlmoravek
changed the title
feat(programmatic): unfiy useProgramamtic interfaces
feat(programmatic): unfiy Sep 20, 2024
useProgramamtic
interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043
With these changes, I refactored the `useProgrammatic' composable, which can open any component programmatically and use it for Oruga's programmatic components. By this the programmatic feature got extracted from the individual component and can be used for any component now.
Proposed Changes
useProgrammatic
composable and addProgrammaticComponent
useModalProgrammatic
,useSidebarProgrammatic
,useLoadingProgrammatic
anduseNotificationProgrammatic
interfacesclose()
interface to all programmatic components, which closes the last open programmatic component in the instance registry stack