Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(programmatic): unfiy useProgramamtic interfaces #1058

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Sep 20, 2024

Fixes #1043

With these changes, I refactored the `useProgrammatic' composable, which can open any component programmatically and use it for Oruga's programmatic components. By this the programmatic feature got extracted from the individual component and can be used for any component now.

Proposed Changes

  • extract programmatic usage out of components
  • refactor useProgrammatic composable and add ProgrammaticComponent
  • cleanup useModalProgrammatic, useSidebarProgrammatic, useLoadingProgrammatic and useNotificationProgrammatic interfaces
  • add close() interface to all programmatic components, which closes the last open programmatic component in the instance registry stack

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 119ab35
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/66ed4c06ea6dfe000813a7ff
😎 Deploy Preview https://deploy-preview-1058--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek changed the title feat(programmatic): unfiy useProgramamtic interfaces feat(programmatic): unfiy useProgramamtic interfaces Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modal.promise typed incorrectly
1 participant