Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): infinity loop #625

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

mlmoravek
Copy link
Member

Fixed datepicker infinity loop.

Fixes #624

Proposed Changes

  • fix changeFocus method
  • refactor focusedDate to prod binding

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 40c4065
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652a66a1ffe9430008ea122e
😎 Deploy Preview https://deploy-preview-625--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek self-assigned this Oct 14, 2023
@mlmoravek mlmoravek added the bug Something isn't working label Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (860d083) 63.48% compared to head (40c4065) 63.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #625      +/-   ##
===========================================
- Coverage    63.48%   63.39%   -0.10%     
===========================================
  Files           86       86              
  Lines         5532     5532              
  Branches      1566     1566              
===========================================
- Hits          3512     3507       -5     
- Misses        1909     1914       +5     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 51.99% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtommy jtommy merged commit fc45dcf into oruga-ui:develop Oct 15, 2023
10 of 11 checks passed
@mlmoravek mlmoravek deleted the fix-datepicker branch October 15, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Datepicker Crashes Browser
2 participants