-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add mode include/exclude to input filters option #1690
Conversation
Running the build now. This looks like a good change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good reinforcement!
I have just one request. we have tests yaml as a regression test in the tests
directory so could you please add a new test case like petstore-filter-exclude-mode
to here?
https://github.com/orval-labs/orval/blob/master/tests/configs/default.config.ts#L9-L18
@soartec-lab no problem! should be ok now (and rebased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbcam
The test failed, could you please check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Thanks!
Status
READY
Description
Fix #1676
Extend the
filters
input option by introducing amode
optional parameter to specify if filtering shouldinclude
orexclude
tags or schemas.Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
Add a tag that should be filtered out to orval.config:
Only endpoints that do not contain the tag "pets" will be generated.