-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(msw): create an index file exporting msw for split tags mode #1803
feat(msw): create an index file exporting msw for split tags mode #1803
Conversation
it's not a fix for me but more a feature no? And for the file name I would |
Agreed i think |
I completely agree with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't support everything at once and continue to use it as before, this aggregated index will be unnecessary and just noise. How about making it optional?
I added a check for |
|
@AllieJonsson also thanks for all you are doing! |
True, I just thought that if you want to have index files for non-mock files, you probably want it for mock files as well. But maybe separating and allowing just having one of them is better. Should it be enabled or disabled by default? |
good point @soartec-lab @melloware I am ok with it either way so if you have thoughts |
This is also really only valid for tags-split mode, right? So adding a whole new setting that only applies to this mode is maybe a bit overkill |
Or maybe this should be added to mode |
yeah we have too many settings already @AllieJonsson 😄 |
It's exactly as @anymaniax wrote. Also, reusing one option for different purposes will complicate things and confuse users. I agree that there are already too many configuration items, but I didn't think it was overkill to create one option for a new use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment I made was about the file extension. The only file type available is msw, so I would like to align them.
Wait, this setting should be in output.mock.indexMockFiles instead of output.indexMockFiles... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllieJonsson
I made one comment to the docs. The rest are fine. Thanks for the great enhance!
Co-authored-by: Shodai Suzuki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Status
READY/WIP
Description
Fixes #512
Is
index.msw.ts
a good name? Or should it be something likemocks.ts
?Steps to Test or Reproduce
index.msw.ts
file which exports * from all .msw.ts files