Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ory Network CORS documentation #1449

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

zepatrik
Copy link
Member

This is very minimal right now, but I was not sure what else to add.

kmherrmann
kmherrmann previously approved these changes Jul 10, 2023
Copy link
Contributor

@kmherrmann kmherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
Once we ship the corresponding Console screen, let's amend the docs accordingly.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid the We form. Avoid wefrom MS styleguide
and a few more minor issues

docs/guides/cors.mdx Outdated Show resolved Hide resolved
docs/guides/cors.mdx Outdated Show resolved Hide resolved
docs/guides/cors.mdx Outdated Show resolved Hide resolved
docs/guides/cors.mdx Outdated Show resolved Hide resolved
docs/guides/cors.mdx Outdated Show resolved Hide resolved

## Supported Endpoints

Currently, only the OAuth2 endpoints support CORS. Others are supported through custom domains, but will follow soon. For OAuth2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, only the OAuth2 endpoints support CORS. Others are supported through custom domains, but will follow soon. For OAuth2,
Only the OAuth2 endpoints support CORS. Others are supported through custom domains, but will follow soon. For OAuth2,

currently is a weasel word
I dont quite get this; other endpoints as OAuth2 (such as?) are supported through CNAME but will get full CORS support (what does that mean) soon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well right now we have a "workaround" on the custom domains (setting the CORS headers in a proxy). This means you cannot configure CORS for your slug URL. See https://github.com/ory-corp/cloud/issues/4460

docs/guides/cors.mdx Outdated Show resolved Hide resolved
docs/guides/cors.mdx Outdated Show resolved Hide resolved
docs/guides/cors.mdx Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Jul 11, 2023

What do you think of moving the CORS document under the API section? https://www.ory.sh/docs/api/

@zepatrik
Copy link
Member Author

What do you think of moving the CORS document under the API section? https://www.ory.sh/docs/api/

I don't really care, wherever you think it makes most sense.

@aeneasr
Copy link
Member

aeneasr commented Jul 11, 2023

ok let's move it there i think it makes sense

@aeneasr aeneasr merged commit fe811d5 into master Jul 17, 2023
@aeneasr aeneasr deleted the feat/cors-in-network branch July 17, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants