Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update webhooks ips #1462

Merged
merged 4 commits into from
Aug 10, 2023
Merged

docs: update webhooks ips #1462

merged 4 commits into from
Aug 10, 2023

Conversation

adamwalach
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@kmherrmann
Copy link
Contributor

kmherrmann commented Jul 18, 2023

Do we need to communicate this to all our clients?

/cc @vinckr

@vinckr
Copy link
Member

vinckr commented Jul 19, 2023

Would be good to include in status.ory.sh as maintenance notice as well as a short announcement in the Slack - we can also add a note to the newsletter.

I am not sure what the impact is - is this relevant if you have some firewall rules around webhooks from Ory Network?

@adamwalach
Copy link
Contributor Author

Yes, I will create a notice in status.ory.sh and send a slack message, the same as we did last time: https://status.ory.sh/maintenance/212371

@vinckr
Copy link
Member

vinckr commented Jul 19, 2023

Yes, I will create a notice in status.ory.sh and send a slack message, the same as we did last time: https://status.ory.sh/maintenance/212371

perfect, I think we can document that as standard practice whenever we make these types of changes that might affect some customers in production.

@kmherrmann
Copy link
Contributor

Maybe we should also send an email about this if it has the potential to break webhooks for those with firewalls?

@vinckr
Copy link
Member

vinckr commented Jul 19, 2023

if you are subscribed to status.ory.sh (which I would recommend to everyone in production) you would get an email I think.
But yea we can include it in the newsletter tomorrow? Or is there a "maintenance" email channel/audience as well?

@kmherrmann
Copy link
Contributor

I think we should create this audience with everyone who is an ory network project member on it.
We can restrict to paid projects to reduce noise.

@kmherrmann
Copy link
Contributor

Newsletter is a good idea but also something that’s easy to overlook

@vinckr
Copy link
Member

vinckr commented Jul 19, 2023

Good point. Something like the security newsletter but just for Ory Network?
Maybe not the right place to discuss it here, but I also need this audience to do the support stuff on Slack. So would go hand in hand to do this in Hubspot i guess.

@kmherrmann
Copy link
Contributor

kmherrmann commented Jul 20, 2023

We should have an email list with all Ory Network users (which are members of a project). We can consider only including paid projects or somehow cutting noise by pruning free projects that haven't seen activity in 90 days (preferred).

This list should not need an opt-out and may only be used for maintenance notifications and potentially sharing information like post mortems. absolutely no marketing, purely necessary information that we expect admins to read. low volume.

@aeneasr
Copy link
Member

aeneasr commented Aug 3, 2023

us is now available - merge this?

@adamwalach adamwalach marked this pull request as ready for review August 8, 2023 10:19
kmherrmann
kmherrmann previously approved these changes Aug 8, 2023
@vinckr vinckr merged commit fd1c7d3 into ory:master Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants