-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve lighthouse score #1478
Conversation
a1ea447
to
4b1aeb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually a good point. It's kind of hard to get a deterministic result there and there might well be some unintended issues. But what you should™️ be able to tell deterministically, is that two issues used to be there that are now gone (image height & width and caching policy, IIRC). You can also make things more uniform by testing against two preview builds (just use another branch's preview), as Vercel may be applying certain optimisations to prod that it doesn't apply to previews. I definitely didn't see such a drastic difference in my tests, but it's totally possible that I did something wrong as well. |
This was on another preview (https://docs-fzoojem2y-ory.vercel.app/docs/welcome), no idea why it is higher now 😅 Have to take a more detailed look tomorrow. |
The previews are typically a bit worse than the live site due to cloudflare optimizations. But if they're worse than other previews then we need to check |
@vinckr please remember to test with https://pagespeed.web.dev/ for consistent results |
Improves the docs' lighthouse score through various measures.