Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LBBO this new cache logic lead to quite serious problems on the documentation. The reason is that it simply is a catch-all cache which sets an insanely high lifetime. This leads to (in hindsight) very obvious problems:
public
directive. This not only stores outdated assets (such as HTML pages) on the client - it stores them in Cloudflare. This significantly makes the problem of broken pages worse due to a shared state.Caching is not an easy problem. Never just cache everything forever, and always roll out caches iteratively and monitor the changes correctly.
Write caching rules that make sense. You want to cache javascript assets that have a hash ID? Sure, do that, it's very unlikely that these files will ever change. Caching
index.html
? Really bad idea, that file will change frequently and the cache MUST NOT be used then.I should have paid more attention during review but thankfully the issue was noticed relatively quickly - we did have a couple of broken pages though, and page health for all of ory.sh deteriorated from 91% to 50%.