Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CTA to ory network #1499

Merged
merged 8 commits into from
Aug 22, 2023
Merged

feat: add CTA to ory network #1499

merged 8 commits into from
Aug 22, 2023

Conversation

LBBO
Copy link
Contributor

@LBBO LBBO commented Aug 10, 2023

This CTA differs a bit from the design in the interest of saving time.

@aeneasr
Copy link
Member

aeneasr commented Aug 10, 2023

Isn't this missing some button i can click on?

@LBBO
Copy link
Contributor Author

LBBO commented Aug 10, 2023

Fixed. Apparently the docusaurus production build just deletes @container queries, lol. But there ended up being no necessity for them, so I just exchanged them for equivalent media queries.

OryTiki
OryTiki suggested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@OryTiki OryTiki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need some work on the button styling or content to ensure most viewports look good.

image

@LBBO LBBO requested a review from OryTiki August 16, 2023 09:21
jfcurran
jfcurran requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@jfcurran jfcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the button text should be centered, this change will do the trick

src/components/OryNetworkCta/ory-network-cta.css Show resolved Hide resolved
vinckr
vinckr reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

only nit is that its not present in the "self-hosting" category, is that on purpose?

@aeneasr aeneasr requested a review from jfcurran August 22, 2023 10:19
@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2023

@vinckr it's only visible if there is a table of contents on the right side: https://docs-fgqd0n2bm-ory.vercel.app/docs/ecosystem/configuring

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2023

#1508

@aeneasr aeneasr merged commit 20074d3 into master Aug 22, 2023
8 checks passed
@aeneasr aeneasr deleted the 1773-ory-network-cta branch August 22, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinckr vinckr vinckr left review comments

@mszekiel mszekiel Awaiting requested review from mszekiel

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

@OryTiki OryTiki Awaiting requested review from OryTiki

@jfcurran jfcurran Awaiting requested review from jfcurran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LBBO @aeneasr @jfcurran @vinckr @OryTiki