Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document how to customize redirect url #1509

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 22, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

docs/identities/sign-in/social-sign-in/redirect-url.mdx Outdated Show resolved Hide resolved
vinckr
vinckr previously approved these changes Aug 22, 2023
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@aeneasr
Copy link
Member Author

aeneasr commented Aug 22, 2023

@vinckr can you please try if it works? :D

@vinckr
Copy link
Member

vinckr commented Aug 22, 2023

I can confirm that it works.

Very important to match the URI everywhere!

@vinckr vinckr merged commit 4df6a1c into master Aug 22, 2023
8 checks passed
@vinckr vinckr deleted the social-sign-in-url branch August 22, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants