Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docs for b2b sso #1544

Merged
merged 2 commits into from
Sep 26, 2023
Merged

feat: docs for b2b sso #1544

merged 2 commits into from
Sep 26, 2023

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Sep 22, 2023

Related Issue or Design Document

Cloud PR: https://github.com/ory-corp/cloud/pull/5301

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

vinckr
vinckr previously requested changes Sep 22, 2023
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good,
a few stylistic improvement suggestions

docs/kratos/organizations/organizations.mdx Outdated Show resolved Hide resolved
docs/kratos/organizations/organizations.mdx Outdated Show resolved Hide resolved
docs/kratos/organizations/organizations.mdx Outdated Show resolved Hide resolved
docs/kratos/organizations/organizations.mdx Outdated Show resolved Hide resolved
docs/kratos/organizations/organizations.mdx Outdated Show resolved Hide resolved
docs/kratos/organizations/organizations.mdx Outdated Show resolved Hide resolved
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Sep 22, 2023
@hperl hperl requested a review from vinckr September 25, 2023 07:03
@hperl hperl merged commit 377d32e into master Sep 26, 2023
8 checks passed
@hperl hperl deleted the hperl/b2b-sso branch September 26, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants