Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: projects API examples #1825

Merged
merged 3 commits into from
Aug 28, 2024
Merged

docs: projects API examples #1825

merged 3 commits into from
Aug 28, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 12, 2024

Related Issue or Design Document

Closes ory/network#217

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

piotrmsc
piotrmsc previously approved these changes Aug 13, 2024
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its great that we have this now, but I would prefer if we dont add a new page.
We already have too many pages in the docs which clutters the sidebar and makes it hard to navigate - can we find a way to add this example somewhere else?

I would prefer in the update to the Projects API blogpost (PR is open here: https://github.com/ory-corp/web/pull/2018)

This is not the hardest API to use, so IMO its fine to have examples only in the blog and in the docs only reference.

@aeneasr
Copy link
Member Author

aeneasr commented Aug 13, 2024

I thought it needs to be in the docs for it to appear in kapa? I'm fine adding all project management to one page or just updating the project API docs

@aeneasr
Copy link
Member Author

aeneasr commented Aug 13, 2024

We will however need to have some type of user guide "delete project" that person X can send to person Y (owner of the org) so they can do it easily (in the future in the UI).

@vinckr
Copy link
Member

vinckr commented Aug 13, 2024

maybe instead of updating the blogpost, we just move the content into the docs as a projects API examples/snippets doc? We also have example for organizations already (so the same API) we can merge all of it in one doc and then link to it as required.
WDYT? Happy to do it in this PR.

we can feed the blogposts also to kapa, that is no issue.

@aeneasr
Copy link
Member Author

aeneasr commented Aug 13, 2024

I was always frustrated by CockroachDB because they hide a lot of developer content (e.g how replication works) in blog posts, and it was difficult to find it. So I agree that it maybe makes sense to have one or two pages in the docs to talk about different use cases like:

A guide to manage your project using the API (create, update, patch delete) with the various options (cli, api, sdk, console)

@vinckr
Copy link
Member

vinckr commented Aug 13, 2024

Ok, I will port over my content from the blogpost to this PR. Should not take too long.

@vinckr
Copy link
Member

vinckr commented Aug 21, 2024

Added the other content and turned the doc into a general guide for that API.
I had to tweak the command a little for it to work on my machine (specifically put the ${API_KEY} into " instead of '), might be due to the terminal I am using?

The delete API didnt work AFAICT though.

@aeneasr
Copy link
Member Author

aeneasr commented Aug 22, 2024

The delete API didnt work AFAICT though.

I fixed it, which is why I'm documenting it :)

@aeneasr
Copy link
Member Author

aeneasr commented Aug 22, 2024

One could also argue that this instead would belong to the API docs. Like Stripe does it: https://docs.stripe.com/api/subscriptions/cancel

Because really, this is API documentation.

@vinckr
Copy link
Member

vinckr commented Aug 22, 2024

One could also argue that this instead would belong to the API docs. Like Stripe does it: https://docs.stripe.com/api/subscriptions/cancel

Because really, this is API documentation.

True its already documented there (minus snippets).
This is why I put it on the blog originally, we can still move it there as tutorial.

@aeneasr
Copy link
Member Author

aeneasr commented Aug 28, 2024

Let's merge this so that it's in the docs and then we can still move it to API docs.

@aeneasr aeneasr merged commit 2e9d24b into master Aug 28, 2024
9 checks passed
@aeneasr aeneasr deleted the delete-project branch August 28, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants