Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move intro sidebar #1909

Closed
wants to merge 1 commit into from
Closed

chore: move intro sidebar #1909

wants to merge 1 commit into from

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Sep 30, 2024

  • moves concepts above guides since those are the intro documents and should be read before jumping into guides. We could alternatively make quickstarts/concepts collapsed.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that guides / tutorials should be at the front and concepts later, even if they are explaining some concepts.

Screenshot 2024-10-14 at 10 40 10

I would rather move some important concepts into the tutorials or guide section

@vinckr
Copy link
Member Author

vinckr commented Oct 14, 2024

Maybe we move the intro documents there?
They would be important to read IMO before jumping into quickstarts.

@vinckr vinckr closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants