Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: passwordless sms login #1911

Merged
merged 2 commits into from
Oct 10, 2024
Merged

docs: passwordless sms login #1911

merged 2 commits into from
Oct 10, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 1, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@@ -29,37 +30,42 @@ import BrowserWindow from "@site/src/theme/BrowserWindow"
In the registration flow below we are only presented an input field for the email address, as we have not defined any other traits
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: below there is no registration view, only direct new configuration section you have added and above there is only a sign-in screen example so the old text does not match the current layout.
Screenshot 2024-10-08 at 08 52 18

Copy link
Collaborator

@piotrmsc piotrmsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do w have any (our) documentation/blogpost that we can link as warning explaining why one should not use OTP via text message?

@aeneasr
Copy link
Member Author

aeneasr commented Oct 9, 2024

Thanks @piotrmsc - addressed your feedback

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aeneasr aeneasr merged commit 4926ae4 into master Oct 10, 2024
9 checks passed
@aeneasr aeneasr deleted the sms-login branch October 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants