-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revoke consent by session id. trigger back channel logout. #2844
base: master
Are you sure you want to change the base?
Conversation
b6b020f
to
b17a044
Compare
b17a044
to
a8fdf3a
Compare
220a774
to
5fd7354
Compare
Codecov Report
@@ Coverage Diff @@
## master #2844 +/- ##
==========================================
+ Coverage 76.85% 76.93% +0.08%
==========================================
Files 124 124
Lines 9164 9253 +89
==========================================
+ Hits 7043 7119 +76
- Misses 1672 1680 +8
- Partials 449 454 +5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4eea405
to
f6586ae
Compare
f6586ae
to
954c972
Compare
daf3ad0
to
e6b1579
Compare
5921eee
to
6a88521
Compare
f305bec
to
a819270
Compare
@aeneasr aside from being out of date with master, is there anything holding this body of work back? |
a819270
to
f5cd46d
Compare
5da0e32
to
1ea545b
Compare
This pull request introduces feature to revoke consent by session id and option to trigger back channel logout.
Use case:
6.1 Logout provider performs
PUT /oauth2/auth/requests/logout/reject
so that user would remain logged in to Application B6.2 Logout provider performs
DELETE /oauth2/auth/sessions/consent?subject=user1&client=applicationA&login_session_id=session1&trigger_backchannel_logout=true
so that user would be logged out from application A (just in case application A did not terminate it's session locally before redirecting to Hydra logout endpoint)Current situation: application A consent from session 1 and session 2 is revoked; backchannel logout is not triggered.
Proposed solution: application A consent only from session 1 is revoked; backchannel logout is triggered.
Triggering backchannel logout is a separate feature and can be used without login_session_id or with all=true parameter.
Related issue(s)
#2666
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
Tests and documentation will be commited after inital acceptance of the proposed feature.