Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use skip consent from OAuth2 client #261

Merged
merged 1 commit into from
Jun 27, 2023
Merged

feat: use skip consent from OAuth2 client #261

merged 1 commit into from
Jun 27, 2023

Conversation

Jorgagu
Copy link
Contributor

@Jorgagu Jorgagu commented Jun 15, 2023 •
edited
Loading

Related Issue or Design Document

Add code to handle the flag skip consent from OAuth2 Client.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Jorgagu Jorgagu changed the title feat: add skip consent for OAuth2 client feat: use skip consent for OAuth2 client Jun 15, 2023
@Jorgagu Jorgagu mentioned this pull request Jun 15, 2023
Merged
6 tasks
@Jorgagu Jorgagu changed the title feat: use skip consent for OAuth2 client feat: use skip consent from OAuth2 client Jun 16, 2023
@aeneasr
Copy link
Member

aeneasr commented Jun 19, 2023

If you run npm format this is good to ship!

@Jorgagu
Copy link
Contributor Author

Jorgagu commented Jun 27, 2023

If you run npm format this is good to ship!

@aeneasr Done ✔️

@Jorgagu Jorgagu marked this pull request as ready for review June 27, 2023 08:39
aeneasr
aeneasr approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit eb0af2a into ory:master Jun 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorgagu @aeneasr