Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings and welcome page should support logout return_to #274

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Aug 7, 2023

Related Issue or Design Document

https://github.com/ory-corp/cloud/issues/3524

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko
Copy link
Contributor Author

Benehiko commented Aug 7, 2023

I've tested this manually, will add some e2e tests for this in Kratos as well

@Benehiko Benehiko mentioned this pull request Aug 7, 2023
7 tasks
@Benehiko Benehiko merged commit 004f7b0 into master Aug 7, 2023
5 checks passed
@Benehiko Benehiko deleted the fix-logout-return-to branch August 7, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants