-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support i18n #284
feat: support i18n #284
Conversation
# Conflicts: # package-lock.json # package.json # src/index.ts # src/routes/login.ts # src/routes/recovery.ts # src/routes/verification.ts # views/layouts/auth.hbs # views/login.hbs # views/registration.hbs # views/settings.hbs
I went though all screens manually on the local hostedui setup and it works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very solid, just a few nits and it should be good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you want to wait for ory/elements#135? |
Yeah let's wait for that fix. |
No description provided.