Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consent and logout integration logic #294

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Sep 18, 2023

Related Issue or Design Document

Further cleanup of the consent route. Added logic to the createHelpers function to inject consent skip logic.

Added the OAuth2 logout endpoint as well.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko Benehiko force-pushed the fix-integrations branch 2 times, most recently from 775f111 to 6c652dc Compare September 18, 2023 14:05
@Benehiko Benehiko marked this pull request as ready for review September 18, 2023 15:13
@Benehiko Benehiko self-assigned this Sep 18, 2023
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

src/index.ts Outdated Show resolved Hide resolved
src/routes/logout.ts Show resolved Hide resolved
@Benehiko Benehiko merged commit 7203db4 into master Sep 27, 2023
5 checks passed
@Benehiko Benehiko deleted the fix-integrations branch September 27, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants