Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect implementation of filterNodesByGroups #326

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Mar 8, 2024

Merging this will fix E2E failures on Kratos master.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl hperl marked this pull request as ready for review March 8, 2024 07:48
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@hperl hperl merged commit 541f3bf into master Mar 8, 2024
10 checks passed
@hperl hperl deleted the hperl/fix-nodes branch March 8, 2024 09:24
@hperl
Copy link
Contributor Author

hperl commented Mar 8, 2024

Add a test?

The kratos-selfservice-ui-node repo "traditionally" has no tests:

"test": "exit 0",

This leads to situations where changes in this repo can break Kratos E2E tests on Kratos master (where the code in this repo is thoroughly tested).

To fix this, I suggest moving this repo into a ui folder in the Kratos repo and have the E2E tests depend on the code in that location. If necessary (I think because the docs reference this repo) we can export the changes with Copybara.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants