Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support IMAGE_TAG build variable #334

Closed
wants to merge 1 commit into from
Closed

build: support IMAGE_TAG build variable #334

wants to merge 1 commit into from

Conversation

jacwil
Copy link

@jacwil jacwil commented May 19, 2024

Makes it easier to build selfservice ui locally

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jacwil seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jacwil jacwil changed the title build: Support IMAGE_TAG build variable build: support IMAGE_TAG build variable May 19, 2024
@jacwil
Copy link
Author

jacwil commented May 19, 2024

Abandoning. Realized that my commit did not have my verified github email address, which is causing CLA check to fail.

@jacwil jacwil closed this May 19, 2024
@jacwil jacwil deleted the jacwil/imagetag branch May 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants