chore: test for null in method receiver (#3990)

ory · Jul 9, 2024 · 2ebdbb0 · 2ebdbb0
1 parent afbcfb2
commit 2ebdbb0
Show file tree

Hide file tree

Showing 10 changed files with 38 additions and 33 deletions.
diff --git a/selfservice/flow/login/error.go b/selfservice/flow/login/error.go
@@ -81,11 +81,8 @@ func (s *ErrorHandler) PrepareReplacementForExpiredFlow(w http.ResponseWriter, r
 func (s *ErrorHandler) WriteFlowError(w http.ResponseWriter, r *http.Request, f *Flow, group node.UiNodeGroup, err error) {
 	logger := s.d.Audit().
 		WithError(err).
-		WithRequest(r)
-
-	if f != nil {
-		logger = logger.WithField("login_flow", f.ToLoggerField())
-	}
+		WithRequest(r).
+		WithField("login_flow", f.ToLoggerField())
 
 	logger.
 		Info("Encountered self-service login error.")

diff --git a/selfservice/flow/login/flow.go b/selfservice/flow/login/flow.go
@@ -328,7 +328,10 @@ func (f *Flow) SetReturnToVerification(to string) {
 	f.ReturnToVerification = to
 }
 
-func (f Flow) ToLoggerField() map[string]interface{} {
+func (f *Flow) ToLoggerField() map[string]interface{} {
+	if f == nil {
+		return map[string]interface{}{}
+	}
 	return map[string]interface{}{
 		"id":            f.ID.String(),
 		"return_to":     f.ReturnTo,

diff --git a/selfservice/flow/recovery/error.go b/selfservice/flow/recovery/error.go
@@ -66,10 +66,9 @@ func (s *ErrorHandler) WriteFlowError(
 ) {
 	logger := s.d.Audit().
 		WithError(recoveryErr).
-		WithRequest(r)
-	if f != nil {
-		logger = logger.WithField("recovery_flow", f.ToLoggerField())
-	}
+		WithRequest(r).
+		WithField("recovery_flow", f.ToLoggerField())
+
 	logger.
 		Info("Encountered self-service recovery error.")
 

diff --git a/selfservice/flow/recovery/flow.go b/selfservice/flow/recovery/flow.go
@@ -249,14 +249,17 @@ func (t *Flow) GetTransientPayload() json.RawMessage {
 	return t.TransientPayload
 }
 
-func (t Flow) ToLoggerField() map[string]interface{} {
+func (f *Flow) ToLoggerField() map[string]interface{} {
+	if f == nil {
+		return map[string]interface{}{}
+	}
 	return map[string]interface{}{
-		"id":          t.ID.String(),
-		"return_to":   t.ReturnTo,
-		"request_url": t.RequestURL,
-		"active":      t.Active,
-		"type":        t.Type,
-		"nid":         t.NID,
-		"state":       t.State,
+		"id":          f.ID.String(),
+		"return_to":   f.ReturnTo,
+		"request_url": f.RequestURL,
+		"active":      f.Active,
+		"type":        f.Type,
+		"nid":         f.NID,
+		"state":       f.State,
 	}
 }
diff --git a/selfservice/flow/registration/error.go b/selfservice/flow/registration/error.go
@@ -86,10 +86,9 @@ func (s *ErrorHandler) WriteFlowError(
 
 	logger := s.d.Audit().
 		WithError(err).
-		WithRequest(r)
-	if f != nil {
-		logger = logger.WithField("registration_flow", f.ToLoggerField())
-	}
+		WithRequest(r).
+		WithField("registration_flow", f.ToLoggerField())
+
 	logger.
 		Info("Encountered self-service flow error.")
 

diff --git a/selfservice/flow/registration/flow.go b/selfservice/flow/registration/flow.go
@@ -280,7 +280,10 @@ func (f *Flow) SetReturnToVerification(to string) {
 	f.ReturnToVerification = to
 }
 
-func (f Flow) ToLoggerField() map[string]interface{} {
+func (f *Flow) ToLoggerField() map[string]interface{} {
+	if f == nil {
+		return map[string]interface{}{}
+	}
 	return map[string]interface{}{
 		"id":          f.ID.String(),
 		"return_to":   f.ReturnTo,

diff --git a/selfservice/flow/settings/error.go b/selfservice/flow/settings/error.go
@@ -142,12 +142,9 @@ func (s *ErrorHandler) WriteFlowError(
 ) {
 	logger := s.d.Audit().
 		WithError(err).
-		WithRequest(r)
+		WithRequest(r).
+		WithField("settings_flow", f.ToLoggerField())
 
-	if f != nil {
-		logger = logger.
-			WithField("settings_flow", f.ToLoggerField())
-	}
 	logger.Info("Encountered self-service settings error.")
 
 	shouldRespondWithJSON := x.IsJSONRequest(r)

diff --git a/selfservice/flow/settings/flow.go b/selfservice/flow/settings/flow.go
@@ -267,6 +267,9 @@ func (t *Flow) GetTransientPayload() json.RawMessage {
 }
 
 func (f *Flow) ToLoggerField() map[string]interface{} {
+	if f == nil {
+		return map[string]interface{}{}
+	}
 	return map[string]interface{}{
 		"id":          f.ID.String(),
 		"return_to":   f.ReturnTo,

diff --git a/selfservice/flow/verification/error.go b/selfservice/flow/verification/error.go
@@ -62,11 +62,9 @@ func (s *ErrorHandler) WriteFlowError(
 ) {
 	logger := s.d.Audit().
 		WithError(err).
-		WithRequest(r)
+		WithRequest(r).
+		WithField("verification_flow", f.ToLoggerField())
 
-	if f != nil {
-		logger = logger.WithField("verification_flow", f.ToLoggerField())
-	}
 	logger.
 		Info("Encountered self-service verification error.")
 

diff --git a/selfservice/flow/verification/flow.go b/selfservice/flow/verification/flow.go
@@ -298,7 +298,10 @@ func (t *Flow) GetTransientPayload() json.RawMessage {
 	return t.TransientPayload
 }
 
-func (f Flow) ToLoggerField() map[string]interface{} {
+func (f *Flow) ToLoggerField() map[string]interface{} {
+	if f == nil {
+		return map[string]interface{}{}
+	}
 	return map[string]interface{}{
 		"id":          f.ID.String(),
 		"return_to":   f.ReturnTo,