Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept all 200 responses as OK in courier #3401

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix: accept all 200 responses as OK in courier #3401

merged 2 commits into from
Aug 1, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 28, 2023

Closes #3399

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner July 28, 2023 10:02
@aeneasr aeneasr requested review from hperl and removed request for zepatrik July 28, 2023 10:03
jonas-jonas
jonas-jonas previously approved these changes Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3401 (7bb0eb8) into master (013f335) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 30.00%.

❗ Current head 7bb0eb8 differs from pull request most recent head 8af97e6. Consider uploading reports for the commit 8af97e6 to get more accurate results

@@           Coverage Diff           @@
##           master    #3401   +/-   ##
=======================================
  Coverage   78.03%   78.03%           
=======================================
  Files         327      327           
  Lines       21373    21370    -3     
=======================================
- Hits        16678    16677    -1     
+ Misses       3458     3456    -2     
  Partials     1237     1237           
Files Changed Coverage Δ
courier/http.go 55.55% <30.00%> (+1.38%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hperl hperl enabled auto-merge (squash) August 1, 2023 06:14
@hperl hperl merged commit 88237e2 into master Aug 1, 2023
21 checks passed
@hperl hperl deleted the fix-3399 branch August 1, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiples retries in courier using SendGrid with mail API
3 participants