Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cypress tests #3531

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix: cypress tests #3531

merged 3 commits into from
Sep 25, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@@ -96,8 +96,6 @@ jobs:
skip-pkg-cache: true
- name: Build Kratos
run: make install
- name: Run documentation tests
run: make test-docs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3531 (9da6cab) into master (bee0341) will decrease coverage by 0.50%.
The diff coverage is n/a.

❗ Current head 9da6cab differs from pull request most recent head 03f9a77. Consider uploading reports for the commit 03f9a77 to get more accurate results

@@            Coverage Diff             @@
##           master    #3531      +/-   ##
==========================================
- Coverage   78.68%   78.18%   -0.50%     
==========================================
  Files         342      341       -1     
  Lines       23470    22769     -701     
==========================================
- Hits        18467    17802     -665     
+ Misses       3639     3626      -13     
+ Partials     1364     1341      -23     

see 12 files with indirect coverage changes

@aeneasr aeneasr merged commit 4206d26 into master Sep 25, 2023
25 of 26 checks passed
@aeneasr aeneasr deleted the jonas-jonas/fixCypress branch September 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants