Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update allowed_return_urls examples in config.schema.json to include wildcard #3533

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

martinloesethjensen
Copy link
Contributor

@martinloesethjensen martinloesethjensen commented Sep 26, 2023

Updated example for allowed_return_urls to include wildcard url.

Merged PR from Nov 9th 2021 for context.

Related issue(s)

None.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Updated example for `allowed_return_urls` to include wildcard url.

[Merged PR from 2021](ory#1528)
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023

CLA assistant check
All committers have signed the CLA.

@martinloesethjensen martinloesethjensen changed the title Update allowed_return_urls examples in config.schema.json to include wildcard docs: Update allowed_return_urls examples in config.schema.json to include wildcard Sep 26, 2023
@martinloesethjensen martinloesethjensen changed the title docs: Update allowed_return_urls examples in config.schema.json to include wildcard docs: update allowed_return_urls examples in config.schema.json to include wildcard Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #3533 (33f4532) into master (ff177db) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 33f4532 differs from pull request most recent head 70e3ff8. Consider uploading reports for the commit 70e3ff8 to get more accurate results

@@            Coverage Diff             @@
##           master    #3533      +/-   ##
==========================================
- Coverage   78.20%   78.20%   -0.01%     
==========================================
  Files         341      341              
  Lines       22767    22769       +2     
==========================================
  Hits        17806    17806              
- Misses       3623     3624       +1     
- Partials     1338     1339       +1     

see 2 files with indirect coverage changes

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 39b0c3c into ory:master Oct 2, 2023
25 checks passed
@martinloesethjensen martinloesethjensen deleted the patch-1 branch October 2, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants