feat: two-step login and improved UI APIs for Ory Elements v1

[aeneasr]

Related issue(s)

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got the approval (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[aeneasr]

OK - we need a proper ID structure then in Ory Elements to deal with that but I agree Am 24.05.2024 um 10:22 schrieb Patrik ***@***.***>: @zepatrik commented on this pull request. In text/message_system.go:

@@ -13,3 +13,11 @@ func NewErrorSystemGeneric(reason string) *Message {

}), } } + +func NewErrorSelfServiceNoMethodsAvailable() *Message { I don't think that we should add any element specific messages here. Kratos is headless, and should only care about the messages it uses. In the previous Ory elements version, we also had two sources of messages for translations, and had a small script to merge the two: https://github.com/ory/elements/blob/a93569f94b252ba193658199559f944162f9b6ab/scripts/generate-locales.ts#L53-L80 I strongly suggest to not add any messages here that are not part of this codebase, as it will become a nightmare to maintain down the road. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[zepatrik]

Previously we used inline definitions, e.g. https://github.com/ory/elements/blob/a93569f94b252ba193658199559f944162f9b6ab/src/react-components/ory/user-auth-card.tsx#L131-L134
This is convenient for developing, as everything is in-place. For IDs we used kind of a namespace approach, but the main mechanism to ensure uniqueness of IDs is the tooling that comes with react-intl.
It extracts all messages from the code and generates the "default" translation, from witch you then create all other translations.

[codecov]

Codecov Report

Attention: Patch coverage is 81.44499% with 113 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (b5a66e0) to head (0da0c9b).

Files	Patch %	Lines
selfservice/strategy/passkey/passkey_login.go	82.22%	12 Missing and 12 partials ⚠️
selfservice/strategy/webauthn/login.go	67.12%	13 Missing and 11 partials ⚠️
selfservice/strategy/idfirst/strategy_login.go	73.86%	11 Missing and 12 partials ⚠️
ui/node/attributes.go	69.38%	13 Missing and 2 partials ⚠️
selfservice/strategy/password/login.go	76.36%	7 Missing and 6 partials ⚠️
selfservice/strategy/oidc/strategy_login.go	78.43%	6 Missing and 5 partials ⚠️
selfservice/flow/login/handler.go	91.66%	2 Missing ⚠️
driver/config/config.go	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3934      +/-   ##
==========================================
+ Coverage   78.23%   78.35%   +0.11%     
==========================================
  Files         365      369       +4     
  Lines       25586    25967     +381     
==========================================
+ Hits        20018    20347     +329     
- Misses       4039     4073      +34     
- Partials     1529     1547      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aeneasr]

In my view this is good to go.

[jonas-jonas]

Let's go 🚀