feat: password migration hook #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hperl
force-pushed
the
hperl/password-migration-hook
branch
from
4182bec
to
bbadd81
Compare
jonas-jonas
requested changes
Jul 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3978 +/- ##
==========================================
+ Coverage 78.21% 78.23% +0.02%
==========================================
Files 363 365 +2
Lines 25516 25586 +70
==========================================
+ Hits 19958 20018 +60
- Misses 4034 4039 +5
- Partials 1524 1529 +5 ☔ View full report in Codecov by Sentry. |
jonas-jonas
previously approved these changes
Jul 2, 2024
hperl
force-pushed
the
hperl/password-migration-hook
branch
from
e1ebd30
to
6c8f8a1
Compare
zepatrik
requested changes
Jul 2, 2024
zepatrik
approved these changes
Jul 2, 2024
jonas-jonas
approved these changes
Jul 3, 2024
aeneasr
reviewed
Jul 4, 2024
| dec := json.NewDecoder(io.LimitReader(resp.Body, 1024)) // limit the response body to 1KB | ||
| var response PasswordMigrationResponse | ||
| if err := dec.Decode(&response); err != nil || response.Status != "password_match" { | ||
| return errors.WithStack(schema.NewInvalidCredentialsError()) |
There was a problem hiding this comment.
This probably needs some tracing or something, because it will be difficult to debug this hook otherwise
aeneasr
reviewed
Jul 4, 2024
| if err := hash.Compare(r.Context(), []byte(p.Password), []byte(o.HashedPassword)); err != nil { | ||
| return nil, s.handleLoginError(w, r, f, &p, errors.WithStack(schema.NewInvalidCredentialsError())) | ||
| } | ||
| if o.ShouldUsePasswordMigrationHook() { |
There was a problem hiding this comment.
Who sets this to false once this is executed successfully? Is it s.migratePasswordHash?
There was a problem hiding this comment.
Yes, if the password hash is not empty, this returns false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a password migration hook to easily migrate passwords for which we do not have the hash.
passwordwith a config of{"use_password_migration_hook": true}.password_migrationweb hook if all of these are true:{"use_password_migration_hook": true}password_migrationhook is configuredpassword_migrationhook, the HTTP status code will be inspected:{"status": "password_match"}. The password credential config will be replaced with the hash of the actual password.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments