Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transient_payload is lost when verification flow started as part of registration #3983

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

splaunov
Copy link
Contributor

@splaunov splaunov commented Jul 3, 2024

This fix copies transient payload from registration flow to new verification flow

Related issue(s)

Checklist

  • [x ] I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [x ] I am following the
    contributing code guidelines.
  • [x ] I have read the security policy.
  • [x ] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, probably would be good to have a test for this, as well.

selfservice/flow/verification/flow.go Outdated Show resolved Hide resolved
@aeneasr aeneasr requested a review from jonas-jonas July 9, 2024 08:48
@aeneasr aeneasr enabled auto-merge (squash) July 9, 2024 08:48
@aeneasr aeneasr merged commit 192f10f into ory:master Sep 16, 2024
26 checks passed
@aeneasr aeneasr deleted the feature/fix-ps-368 branch September 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants