Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate page tokens for better error codes #4021

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Aug 2, 2024

Currently the error returned is similar to unable to fetch records: ERROR: error in argument for $2: could not parse "1" as type uuid: could not parse "1" as type uuid: uuid: incorrect UUID length: 1 (SQLSTATE 22P02).

jonas-jonas
jonas-jonas previously approved these changes Aug 2, 2024
persistence/sql/identity/persister_identity.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (7945104) to head (97cea84).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
persistence/sql/identity/persister_identity.go 0.00% 1 Missing and 1 partial ⚠️
persistence/sql/persister_session.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
- Coverage   78.39%   78.37%   -0.02%     
==========================================
  Files         370      370              
  Lines       26127    26133       +6     
==========================================
  Hits        20481    20481              
- Misses       4088     4092       +4     
- Partials     1558     1560       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zepatrik zepatrik merged commit 32737dc into master Sep 2, 2024
28 of 29 checks passed
@zepatrik zepatrik deleted the fix/validate-page-token branch September 2, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants