Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add google to supported providers in ID Token doc strings #4026

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (4fb28b3) to head (2aa24e6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4026      +/-   ##
==========================================
- Coverage   78.35%   78.35%   -0.01%     
==========================================
  Files         370      370              
  Lines       26102    26108       +6     
==========================================
+ Hits        20452    20456       +4     
  Misses       4092     4092              
- Partials     1558     1560       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I think this works for almost every openid connect provider?

@jonas-jonas
Copy link
Member Author

No it's only implemented for Google and Apple yet.

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2024

Are you sure?

func (s *Strategy) processIDToken(w http.ResponseWriter, r *http.Request, provider Provider, idToken, idTokenNonce string) (*Claims, error) {

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2024

Screenshot 2024-08-07 at 16 13 36

@jonas-jonas
Copy link
Member Author

That method expects the provider to implement IDTokenVerifier, which only google and apple do.

verifier, ok := provider.(IDTokenVerifier)

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2024

Makes sense!

@aeneasr aeneasr merged commit 955bd8f into master Aug 7, 2024
31 checks passed
@aeneasr aeneasr deleted the jonas-jonas/fixIDtokenDocs branch August 7, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants