Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor internal API to prevent panics #4028

Merged
merged 1 commit into from
Aug 12, 2024

fix(refactor): internal API to prevent panics

fd6fffe
Select commit
Loading
Failed to load commit list.
Merged

fix: refactor internal API to prevent panics #4028

fix(refactor): internal API to prevent panics
fd6fffe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2024 in 0s

78.37% (target 70.00%)

View this Pull Request on Codecov

78.37% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 61.65049% with 79 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (955bd8f) to head (fd6fffe).
Report is 2 commits behind head on master.

Files Patch % Lines
selfservice/strategy/lookup/settings.go 59.25% 4 Missing and 7 partials ⚠️
selfservice/strategy/code/strategy_verification.go 44.44% 10 Missing ⚠️
selfservice/strategy/link/strategy_verification.go 52.38% 10 Missing ⚠️
...fservice/strategy/profile/two_step_registration.go 20.00% 7 Missing and 1 partial ⚠️
selfservice/strategy/webauthn/registration.go 56.25% 7 Missing ⚠️
selfservice/strategy/totp/settings.go 72.72% 4 Missing and 2 partials ⚠️
selfservice/strategy/idfirst/strategy_login.go 37.50% 5 Missing ⚠️
selfservice/strategy/password/registration.go 54.54% 5 Missing ⚠️
selfservice/strategy/passkey/passkey_settings.go 55.55% 4 Missing ⚠️
selfservice/strategy/password/login.go 66.66% 3 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4028      +/-   ##
==========================================
+ Coverage   78.35%   78.37%   +0.02%     
==========================================
  Files         370      370              
  Lines       26113    26120       +7     
==========================================
+ Hits        20460    20472      +12     
+ Misses       4094     4090       -4     
+ Partials     1559     1558       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov