Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve OIDC account linking UI #4036

Merged
merged 11 commits into from
Aug 30, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Aug 13, 2024

Improves the account linking UI, to only show relevant options to the user. E.g. if the user previously registered using a password, but tries to log into the account using Google, we only show the password input. Similarly, if they used Apple the first time, and Google on the next login, they would only see the Apple login button. If they have both a password and Apple set up, Ory Kratos will show both as options.

Related issue(s)

Fixes #5983

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (76af303) to head (34cd276).
Report is 3 commits behind head on master.

Files Patch % Lines
selfservice/strategy/oidc/strategy.go 93.47% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4036      +/-   ##
==========================================
+ Coverage   78.39%   78.41%   +0.02%     
==========================================
  Files         370      370              
  Lines       26127    26155      +28     
==========================================
+ Hits        20481    20509      +28     
  Misses       4088     4088              
  Partials     1558     1558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review August 20, 2024 19:17
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice! I just added two comments below, but nothing major. Brilliant!

selfservice/strategy/oidc/strategy.go Show resolved Hide resolved
selfservice/strategy/oidc/strategy.go Show resolved Hide resolved
@jonas-jonas jonas-jonas changed the title fix: improve account linking UI fix: improve OIDC account linking UI Aug 23, 2024
text/message_login.go Outdated Show resolved Hide resolved
@aeneasr aeneasr requested a review from hperl August 27, 2024 17:09
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aeneasr
Copy link
Member

aeneasr commented Aug 30, 2024

Needs a merge, then good to go!

@aeneasr aeneasr merged commit 2b4a618 into master Aug 30, 2024
27 checks passed
@aeneasr aeneasr deleted the jonas-jonas/fixAccountLinkingMessages branch August 30, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants