chore: don't return allowed return URLs #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4044 +/- ##
===========================================
+ Coverage 0 78.34% +78.34%
===========================================
Files 0 370 +370
Lines 0 26118 +26118
===========================================
+ Hits 0 20461 +20461
- Misses 0 4096 +4096
- Partials 0 1561 +1561 ☔ View full report in Codecov by Sentry. |
hperl
approved these changes
Aug 21, 2024
aeneasr
requested changes
Aug 23, 2024
| WithDebugf("Allowed domains are: %v", strings.Join(lo.Map(o.allowlist, func(u url.URL, _ int) string { | ||
| return u.String() | ||
| }), ", "))) | ||
| WithReasonf("Requested return_to URL %q is not allowed.", returnTo), |
There was a problem hiding this comment.
Log this instead then? Or trace?
There was a problem hiding this comment.
I don't think that adds any value, because you can always check the project configuration.
I added this a while back mainly to make live for a developer implementing Ory a little easier, but in this configuration we're leaking this information to end users if they deliberately trigger this error (e.g. by providing an illegal return_to).
aeneasr
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments