Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow partially failing batch inserts #4083

Merged
merged 27 commits into from
Sep 17, 2024

test: always use www.example.org as return_to URL in tests

03c127c
Select commit
Loading
Failed to load commit list.
Merged

feat: allow partially failing batch inserts #4083

test: always use www.example.org as return_to URL in tests
03c127c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 11, 2024 in 1s

78.53% (target 70.00%)

View this Pull Request on Codecov

78.53% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 81.20805% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (122b63d) to head (03c127c).

Files with missing lines Patch % Lines
persistence/sql/identity/persister_identity.go 80.00% 9 Missing and 4 partials ⚠️
persistence/sql/batch/create.go 63.63% 9 Missing and 3 partials ⚠️
identity/manager.go 95.23% 1 Missing and 1 partial ⚠️
identity/handler.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4083      +/-   ##
==========================================
+ Coverage   78.50%   78.53%   +0.02%     
==========================================
  Files         373      373              
  Lines       26563    26656      +93     
==========================================
+ Hits        20854    20933      +79     
- Misses       4119     4127       +8     
- Partials     1590     1596       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov