Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add return_to query parameter to OAS Verification Flow for Native Apps #4086

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Sep 10, 2024

The idea would be to re-generate the Kratos SDK, so that one can specify a return_to URL when creating a Native Verification Flow using the SDK.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@David-Wobrock David-Wobrock changed the title docs: add return_to query parameter to OAS Verification Flow for Nati… docs: add return_to query parameter to OAS Verification Flow for Native Apps Sep 10, 2024
@David-Wobrock David-Wobrock force-pushed the docs/return_to-query-param-native-verification-flow branch from 8ea230f to a3c4946 Compare September 12, 2024 07:27
@David-Wobrock David-Wobrock marked this pull request as ready for review September 12, 2024 08:34
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and the return_to parameter is not being used anywhere in the verification flow, so this change has no effect. We would instead need to implement return_to support.

What's your use case?

@David-Wobrock David-Wobrock force-pushed the docs/return_to-query-param-native-verification-flow branch from a3c4946 to e65d506 Compare September 27, 2024 08:35
@David-Wobrock David-Wobrock force-pushed the docs/return_to-query-param-native-verification-flow branch from e65d506 to 191908e Compare September 27, 2024 08:54
@aeneasr aeneasr merged commit b22135f into ory:master Oct 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants