Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect append of code credential identifier #4102

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Sep 16, 2024

Closes #4076

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (7d6a458) to head (d4465fe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4102   +/-   ##
=======================================
  Coverage   78.48%   78.49%           
=======================================
  Files         376      376           
  Lines       26755    26752    -3     
=======================================
  Hits        20998    20998           
+ Misses       4155     4152    -3     
  Partials     1602     1602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 3215792 into master Sep 16, 2024
29 checks passed
@aeneasr aeneasr deleted the fix-4076 branch September 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential Identifiers Are Appended, Not Updated, When Changing the email Trait
1 participant