feat: delegate SMS code generation, sending and verification to an external service (PS-221) #4113
+2,095
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal service (PS-221) ignore: respond 400 when code is invalid (PS-307) ignore: accept all http codes from 200-300 range ignore: add `body` parameter to request config schema (PS-221) feat: delegate SMS code generation, sending and verification to an external service - registration flow (PS-262) feat: delegate SMS code generation, sending and verification to an external service - login flow (PS-263) feat: delegate SMS code generation, sending and verification to an external service - verification flow (PS-221)
|
|
|
Looks like your branch and master have divereged. We recently merged improvements to SMS which probably cause the conflicts. |
|
Yes, we are a bit behind the master. |
|
The problem described is definitely something we should consider. Regarding the approach, I'm not sure if I fully understand how it works, but it does look a bit "strapped on" from first glance, with hardcoded values and some other things, which make me question if it wouldn't be better to use hooks and transient payloads for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phone/sms registration and login flows are vulnerable to sms pumping attacks.
This PR allows to delegate all the key steps of the flow to an external service which is able to detect sms pumping and throttle requests.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments