Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change method=profile:back to screen=previous #4119

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Sep 24, 2024

BREAKING CHANGE: When using two-step registration, it was previously possible to send method=profile:back to get to the previous screen. This feature was not documented in the SDK API yet. Going forward, please instead use screen=previous.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

BREAKING CHANGE: When using two-step registration, it was previously possible to send `method=profile:back` to get to the previous screen. This feature was not documented in the SDK API yet. Going forward, please instead use `screen=previous`.
@mszekiel
Copy link
Contributor

Would it be possible to additionally unify the behavior between login and registration? Right now login provides identifier_first node which has similar role than the profile:back if I understand that correctly.

But I believe this is some amount of additional work.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (340f698) to head (d52215f).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...fservice/strategy/profile/two_step_registration.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4119      +/-   ##
==========================================
+ Coverage   78.63%   78.65%   +0.01%     
==========================================
  Files         377      377              
  Lines       26942    26942              
==========================================
+ Hits        21185    21190       +5     
+ Misses       4146     4142       -4     
+ Partials     1611     1610       -1     
Flag Coverage Δ
78.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr
Copy link
Member Author

aeneasr commented Sep 25, 2024

Would it be possible to additionally unify the behavior between login and registration? Right now login provides identifier_first node which has similar role than the profile:back if I understand that correctly.

That is kind of correct, I wanted to add a back button but decided against it due to time constraints, and used the identifier_first node as sort of a "workaround". But it's not good, because it adds an implicit dependency on this node.

I'm not entirely sure how to best handle this. Ideally we would have something like login_hint in the login flow object that is the identifier of the user, and maybe add a back button to identifier first auth.

@jonas-jonas wdyt?

@aeneasr aeneasr merged commit 2cd8483 into master Sep 25, 2024
28 of 29 checks passed
@aeneasr aeneasr deleted the fix-profile-back branch September 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants